Add DecomposeDataflowPass to flatten compound data types.#4138
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Add DecomposeDataflowPass to flatten compound data types.#4138copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This pass transforms IR by replacing operations on arrays and tuples with equivalent operations on their individual leaf elements (bits or empty tuples). This is achieved by using a dataflow visitor that tracks the decomposition of compound types. Key transformations include: - Replacing array/tuple operations like ArrayIndex, ArrayUpdate, ArraySlice, ArrayConcat, TupleIndex with equivalent logic using Selects and operations on leaf elements. - Decomposing operands of higher-order operations like Invoke, Map, CountedFor, Send, and Next. - Handling Select, PrioritySelect, and OneHotSelect by reconstructing them on the decomposed leaf elements. This pass is intended for development and testing purposes, allowing analysis and optimization on a flattened representation of the IR. Also, add a `CloneSelectLike` method to `GenericSelect` to facilitate creating new select-like nodes with different selectors. PiperOrigin-RevId: 902695281
0c4f762 to
bc505da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DecomposeDataflowPass to flatten compound data types.
This pass transforms IR by replacing operations on arrays and tuples with equivalent operations on their individual leaf elements (bits or empty tuples). This is achieved by using a dataflow visitor that tracks the decomposition of compound types.
Key transformations include:
This pass is intended for development and testing purposes, allowing analysis and optimization on a flattened representation of the IR.
Also, add a
CloneSelectLikemethod toGenericSelectto facilitate creating new select-like nodes with different selectors.