ScreenshotSynthesizer: Render at a smaller 640 resolution #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruofeidu
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ScreenshotSynthesizer creates dataurls of the current viewport in order to sent to Gemini in demos like Gemini Icebreakers.
Previously, we would take the existing render texture and get a dataurl from it. This is slow and takes up a bunch of memory because the full viewport resolution can be very large. So instead we should get a smaller resolution to save on encoding time and memory usage. On Quest 3, we can't seem to reuse the render target as a texture so I'm now doing an actual render pass of the main scene into a new render texture.
This PR also fixes an issue where the image we were sending to Gemini was very dark.
Example image from quest 3:
Performance before, where toDataURL would take 100-300 ms on Quest 3
Performance after on Quest 3:
Tested on Quest 3, desktop simulator, and Moohan.