Change ref_from_bytes() to inline(always).#3137
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You'll want to run |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 20 20
Lines 6057 6057
=======================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When building my firmware for rv32imc with lto=fat, changing codegen-units from 16 to 1 influences the compiler heuristics enough to *not* inline this function, causing code bloat and unnecessary panic logic.
|
hmm, those benchmark changes don't look good :( |
jswrenn
left a comment
There was a problem hiding this comment.
The benchmark results are fine. :-) There's only a six instructions overhead on the dynamic padding case, and a hypothetical cycle improvement in the dynamic size case. Since dynamically padded types are unusual, not too much weight should be put in optimizing them relative to unpadded dynamically sized types.
When building my firmware for rv32imc with lto=fat, changing codegen-units from 16 to 1 influences the compiler heuristics enough to not inline this function, causing code bloat and unnecessary panic logic.