Fixed not writing specs to directory#10
Closed
iamwilhelm wants to merge 4 commits intogoogleapis:masterfrom
Closed
Fixed not writing specs to directory#10iamwilhelm wants to merge 4 commits intogoogleapis:masterfrom
iamwilhelm wants to merge 4 commits intogoogleapis:masterfrom
Conversation
It wasn’t writing before, because body was
{body, “default”}, which is a keymap, and not a
string. And the with statement didn’t have the
mechanism to report what was wrong.
That’s because it needed the openapi directory to exist, and it wasn’t already created.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
|
Thanks for the PR! For fetching, the 404s will go away when I remove the APIs that should not be there. For converting, we should ensure that the openapi directory exists, or create it. (Created #12) For generating the client, you are getting empty files and not the latest generated code as we are using the fork from the pending PR to swagger-codegen (so it's not in the master image). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code had problems at every stage:
Fetching stage
During fetching, it wasn't writing anything to the directory, because it was trying to write a keymap to file, instead of a string.
Also, the key for the spec listings in the discovery file changed from
urltodiscoveryRestUrl.I changed the
withstatements tocase, just so I could get it working, and I understood it. Uglier, but it works.Conversion stage
Similar problem as fetching, but it wasn't writing, because the directory
openapihad never been createdBuild stage
Just had to state what the current docker image should be.
However, had a question here...once I generated the client, it had all these new empty files that were generated. Is that suppose to happen?