Skip to content

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jun 16, 2020

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2020
@busunkim96 busunkim96 force-pushed the client-options-credentials branch from 558ba06 to 50efda5 Compare June 17, 2020 00:43
@busunkim96 busunkim96 force-pushed the client-options-credentials branch from 8b27827 to b287451 Compare June 19, 2020 02:17
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #461 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #461   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1466      1466           
  Branches       300       300           
=========================================
  Hits          1466      1466           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fe7e7...b938080. Read the comment docs.

@busunkim96 busunkim96 marked this pull request as ready for review June 19, 2020 02:28
@busunkim96 busunkim96 requested a review from software-dov June 19, 2020 20:22
@busunkim96
Copy link
Contributor Author

@software-dov Any idea what's up with the showcase tests?

@busunkim96 busunkim96 merged commit b5e1b1e into master Jun 30, 2020
@busunkim96 busunkim96 deleted the client-options-credentials branch June 30, 2020 20:26
busunkim96 added a commit that referenced this pull request Jul 9, 2020
This is the version required for credentials_file and scopes support via google-api-core. (#461)
software-dov added a commit that referenced this pull request Jul 10, 2020
This is the version required for credentials_file and scopes support via google-api-core. (#461)

Co-authored-by: Dov Shlachter <dovs@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clients should support scope override via client_options

3 participants