ci: java8 build with java11 compilation #1671

suztomo · 2022-05-04T18:50:11Z

Java 8 build: compiling the code in JDK 11 and running tests in JDK 8.
Release build: compiling the code in JDK 11.

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

suztomo · 2022-05-04T19:25:19Z

.github/workflows/ci.yaml

+    - uses: actions/checkout@v3
+    - uses: actions/setup-java@v3
+      with:
+        java-version: 8
+        distribution: zulu
+    - run: echo "JAVA8_HOME=${JAVA_HOME}" >> $GITHUB_ENV
+    - uses: actions/setup-java@v3
+      with:
+        java-version: 11
+        distribution: zulu
+    - run: echo "JAVA11_HOME=${JAVA_HOME}" >> $GITHUB_ENV


This job now requires 2 JDKs.

suztomo · 2022-05-04T19:25:41Z

.kokoro/build.sh

+echo "Compiling using Java:"
+java -version
+echo
+./gradlew compileJava compileTestJava


This doesn't run tests.

suztomo · 2022-05-04T19:25:56Z

.kokoro/build.sh

+./gradlew build publishToMavenLocal \
+  --exclude-task compileJava --exclude-task compileTestJava


This runs tests without re-compiling.

suztomo · 2022-05-04T19:26:46Z

build.gradle

+    // This flag is only available in JDK 9+
+    options.compilerArgs.addAll(['--release', '8'])


This flag ensures the generated bytecode is compatible with Java 8. (targetCompatibility = 1.8 is not sufficient)

Could we make this a source code comment?

suztomo · 2022-05-04T19:30:04Z

dependencies.properties

 maven.javax_annotation_javax_annotation_api=javax.annotation:javax.annotation-api:1.3.2
 maven.org_graalvm_nativeimage_svm=org.graalvm.nativeimage:svm:22.0.0.2
-maven.org_graalvm_sdk=org.graalvm.sdk:graal-sdk:21.3.2
+maven.org_graalvm_sdk=org.graalvm.sdk:graal-sdk:22.1.0


This is the dependency that was failing Java 8 build #1669

Not actionable: Given the new behavior introduced in 22.1.0, this might cause some of our Kokoro GraalVM builds to be temporarily red.

I missed to remove this. This was a test to confirm the build passes. Reverted in this PR.

Ah got it, thanks.

suztomo · 2022-05-04T19:59:51Z

@mpeddada1 @meltsufin It worked. Building the modules in JDK 11 and running tests in Java 8.

ci / units (8) (pull_request) Successful in 2m

mpeddada1 · 2022-05-04T20:07:16Z

That's wonderful news!

.kokoro/release/common.cfg

mpeddada1 · 2022-05-10T15:42:34Z

build.gradle

+    // This flag is only available in JDK 9+
+    options.compilerArgs.addAll(['--release', '8'])


Could we make this a source code comment?

mpeddada1 · 2022-05-10T15:45:56Z

dependencies.properties

 maven.javax_annotation_javax_annotation_api=javax.annotation:javax.annotation-api:1.3.2
 maven.org_graalvm_nativeimage_svm=org.graalvm.nativeimage:svm:22.0.0.2
-maven.org_graalvm_sdk=org.graalvm.sdk:graal-sdk:21.3.2
+maven.org_graalvm_sdk=org.graalvm.sdk:graal-sdk:22.1.0


Not actionable: Given the new behavior introduced in 22.1.0, this might cause some of our Kokoro GraalVM builds to be temporarily red.

mpeddada1

LGTM. Added a few minor comments!

meltsufin · 2022-05-10T15:55:14Z

.kokoro/build.sh

+  export PATH=${JAVA_HOME}/bin:$PATH
+}
+
+# GraalVM dependencies require to compiling the classes in JDK 11 or higher


Should there be an explicit check that JDK 11 or higher and JDK 8 are configured, and fail otherwise?

I added source code comment here about how it fails in Java 8.

meltsufin

My concern is that if you intend to test with Java 8, but forget to configure it correctly, you won't see any failure. Maybe you can add an argument to the script that specifies compilation JDK and runtime JVM version, so that you can validate that the script actually does what's intended by the caller.

sonarqubecloud · 2022-05-10T19:07:53Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

suztomo · 2022-05-10T19:11:51Z

@meltsufin PTAL. Added a check to confirm it's using JDK 8 for running the Java 8 test.

cd24fe5

suztomo requested a review from a team May 4, 2022 18:50

suztomo requested review from a team as code owners May 4, 2022 18:50

suztomo marked this pull request as draft May 4, 2022 18:50

suztomo force-pushed the java11-java8-build branch from d548a55 to 1068273 Compare May 4, 2022 18:51

ci: java8 build with java11 compilation

20da203

suztomo force-pushed the java11-java8-build branch from 1068273 to 20da203 Compare May 4, 2022 18:52

suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 4, 2022

suztomo added 3 commits May 4, 2022 14:59

ci: build script to distinguish JDK 11 and JDK 8

cb7d86b

ci: using GITHUB_ENV

a4b2a4b

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

build: javac to take '--release 8' flag

76e9219

suztomo force-pushed the java11-java8-build branch 2 times, most recently from 088b709 to 96b5ca2 Compare May 4, 2022 19:19

build: compileTestJava in Java11

c4c6999

suztomo force-pushed the java11-java8-build branch from 96b5ca2 to c4c6999 Compare May 4, 2022 19:20

ci: job name to align required checks

83527ad

suztomo commented May 4, 2022

View reviewed changes

deps: trying new GraalVM SDK 22.1.0

709fc91

suztomo commented May 4, 2022

View reviewed changes

build: not running javadoc in Java 8

a377d1d

suztomo force-pushed the java11-java8-build branch from ae4f9a0 to a377d1d Compare May 4, 2022 19:51

ci: use JDK 11 for release, targeting Java 8

19ca743

suztomo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 10, 2022

suztomo marked this pull request as ready for review May 10, 2022 15:34

suztomo added the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2022

suztomo changed the title ~~ci: java8 build with java11 compilation~~ feat: java8 build with java11 compilation May 10, 2022

suztomo changed the title ~~feat: java8 build with java11 compilation~~ ci: java8 build with java11 compilation May 10, 2022

mpeddada1 reviewed May 10, 2022

View reviewed changes

mpeddada1 approved these changes May 10, 2022

View reviewed changes

meltsufin suggested changes May 10, 2022

View reviewed changes

deps: reverted GraalVM version

852bdce

suztomo requested a review from meltsufin May 10, 2022 16:27

suztomo force-pushed the java11-java8-build branch from 6eb83ad to 1e21d5b Compare May 10, 2022 17:19

docs: added source code comments

636c5e5

suztomo force-pushed the java11-java8-build branch from 1e21d5b to 636c5e5 Compare May 10, 2022 17:22

meltsufin reviewed May 10, 2022

View reviewed changes

ci: fail build if Java 8 is not specified for junit-java8

cd24fe5

suztomo requested a review from meltsufin May 10, 2022 19:12

meltsufin approved these changes May 10, 2022

View reviewed changes

suztomo merged commit 4483643 into googleapis:main May 10, 2022

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2022

suztomo deleted the java11-java8-build branch May 10, 2022 20:31

mpeddada1 mentioned this pull request May 11, 2022

chore: set Java header at native image runtime googleapis/google-api-java-client#2069

Merged

XN137 mentioned this pull request Jul 4, 2022

threetenbp and java 8 #1293

Closed

mpeddada1 mentioned this pull request May 28, 2025

chore: replace AlloyDBFeature with static JSON config GoogleCloudPlatform/alloydb-java-connector#645

Merged

		./gradlew build publishToMavenLocal \
		--exclude-task compileJava --exclude-task compileTestJava

		// This flag is only available in JDK 9+
		options.compilerArgs.addAll(['--release', '8'])

ci: java8 build with java11 compilation #1671

ci: java8 build with java11 compilation #1671

Conversation

suztomo commented May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo commented May 4, 2022

Uh oh!

mpeddada1 commented May 4, 2022

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mpeddada1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

meltsufin left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 10, 2022

Uh oh!

suztomo commented May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

suztomo commented May 4, 2022 •

edited

Loading

suztomo commented May 10, 2022 •

edited

Loading