Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Sep 26, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2018
@codecov-io
Copy link

Codecov Report

Merging #582 into master will increase coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #582      +/-   ##
============================================
+ Coverage      74.2%   75.03%   +0.83%     
- Complexity      905      935      +30     
============================================
  Files           176      177       +1     
  Lines          4047     4090      +43     
  Branches        316      323       +7     
============================================
+ Hits           3003     3069      +66     
+ Misses          893      869      -24     
- Partials        151      152       +1
Impacted Files Coverage Δ Complexity Δ
...api/gax/grpc/InstantiatingGrpcChannelProvider.java 65.38% <0%> (-9.81%) 26% <0%> (+1%)
...le/api/gax/retrying/ScheduledRetryingExecutor.java 92.3% <0%> (-7.7%) 3% <0%> (ø)
...va/com/google/api/gax/retrying/RetryAlgorithm.java 85.71% <0%> (-7.15%) 7% <0%> (-1%)
...oogle/api/gax/retrying/DirectRetryingExecutor.java 78.94% <0%> (-4.39%) 6% <0%> (ø)
...om/google/api/gax/httpjson/HttpJsonStatusCode.java 28.2% <0%> (-2.57%) 7% <0%> (-1%)
...le/api/gax/retrying/ExponentialRetryAlgorithm.java 97.43% <0%> (-0.07%) 10% <0%> (ø)
.../com/google/api/gax/rpc/OperationCallableImpl.java 100% <0%> (ø) 5% <0%> (ø) ⬇️
.../api/gax/retrying/CallbackChainRetryingFuture.java 88.37% <0%> (ø) 6% <0%> (ø) ⬇️
...ava/com/google/api/gax/retrying/RetrySettings.java 31.25% <0%> (ø) 2% <0%> (ø) ⬇️
...rc/main/java/com/google/api/gax/rpc/Callables.java 68.18% <0%> (ø) 7% <0%> (ø) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffc665...e402509. Read the comment docs.

Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit 7c29452 into googleapis:master Oct 19, 2018
@elharo elharo deleted the patch-1 branch October 19, 2018 18:22
Raibaz pushed a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018
Raibaz pushed a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants