This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Fix rpcTimeout calculation in retrying logic #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #604 +/- ##
============================================
- Coverage 75.1% 75.09% -0.01%
Complexity 935 935
============================================
Files 176 176
Lines 4085 4084 -1
Branches 323 323
============================================
- Hits 3068 3067 -1
Misses 865 865
Partials 152 152
Continue to review full report at Codecov.
|
Raibaz
pushed a commit
to Raibaz/gax-java
that referenced
this pull request
Oct 25, 2018
The the initial rpc timeout was mistakenly used twice (instead of using calculated value on the second attempt). The actual impact on the existing clients is minimal, but it is still a bug, which should be fixed.
Raibaz
pushed a commit
to Raibaz/gax-java
that referenced
this pull request
Oct 25, 2018
The the initial rpc timeout was mistakenly used twice (instead of using calculated value on the second attempt). The actual impact on the existing clients is minimal, but it is still a bug, which should be fixed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The the initial rpc timeout was mistakenly used twice (instead of using calculted value on the second attempt). The actual impact on the existing clients is minimal, but it is still a bug, which should be fixed.