Converting from uploadArchives to publications #605

garrettjonesgoogle · 2018-10-12T22:10:24Z

Fixes #603

For some reason, maven-publish doesn't seem to pick up the version set by sub-module build.gradle files, so it needs to be set in the submodules section of the main build.gradle file.

I have tested by running the following (after locally bumping the version):

./gradlew publishMavenJavaPublicationToMavenRepository

codecov-io · 2018-10-12T22:13:33Z

Codecov Report

Merging #605 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #605   +/-   ##
=========================================
  Coverage     75.03%   75.03%           
  Complexity      935      935           
=========================================
  Files           177      177           
  Lines          4090     4090           
  Branches        323      323           
=========================================
  Hits           3069     3069           
  Misses          869      869           
  Partials        152      152

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90957ff...f6fc277. Read the comment docs.

vam-google

Magic & Unicorns

CONTRIBUTING.md

+To install GAX into the local maven repository:
+
+```sh
+./gradlew publishToMavenLocal -Pskip.signing


build.gradle

-
+  apply plugin: 'maven-publish'
+
+  if (project.name.equals("gax")) {


build.gradle

+            packaging = 'jar'
+            artifactId = project.name
+            description = 'Google Api eXtensions'
+            url = 'https://github.com/googleapis'


build.gradle

-            description 'Google Api eXtensions'
-            url 'https://github.com/googleapis'
+          pom {
+            name = 'GAX (Google Api eXtensions)'


build.gradle

-                url 'https://github.com/googleapis'
-                organization 'Google, Inc.'
-                organizationUrl 'https://www.google.com'
+                id = 'GoogleAPIs'


build.gradle

      // We need to spawn a new gradle build process in order to upload appropriately
      // More details: http://stackoverflow.com/questions/31614735/gradle-uploadarchives-artificats-namespace-when-depending-on-a-plugin
-      commandLine './gradlew', 'uploadArchives'
+      commandLine './gradlew', 'publishMavenJavaPublicationToMavenRepository'


garrettjonesgoogle · 2018-10-16T16:00:37Z

Made one edit - PTAL

vam-google

LGTM

Converting from uploadArchives to publications

1aeb124

garrettjonesgoogle requested review from chingor13 and vam-google October 12, 2018 22:10

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2018

vam-google reviewed Oct 15, 2018

View reviewed changes

Using shorter command for publishing

54f787b

garrettjonesgoogle added 2 commits October 16, 2018 14:38

Moving versions back into module build.gradle files

9c289f0

Merge branch 'master' of https://github.com/googleapis/gax-java

f6fc277

vam-google approved these changes Oct 16, 2018

View reviewed changes

garrettjonesgoogle merged commit 638c5cc into googleapis:master Oct 16, 2018

garrettjonesgoogle mentioned this pull request Oct 19, 2018

Release gax-java v1.34.0 #611

Merged

Raibaz pushed a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018

Converting from uploadArchives to publications (googleapis#605)

9cb5707

Raibaz pushed a commit to Raibaz/gax-java that referenced this pull request Oct 25, 2018

Converting from uploadArchives to publications (googleapis#605)

bde9851


		apply plugin: 'maven-publish'

		if (project.name.equals("gax")) {

Converting from uploadArchives to publications #605

Converting from uploadArchives to publications #605

Uh oh!

Conversation

garrettjonesgoogle commented Oct 12, 2018

Uh oh!

codecov-io commented Oct 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Oct 16, 2018

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-io commented Oct 12, 2018 •

edited

Loading