This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Provide a way to configure the ManagedChannelBuilder when building gRPC channels in InstantiatingGrpcChannelProvider #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PC channels in InstantiatingGrpcChannelProvider Fixes googleapis#573
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
============================================
+ Coverage 74.94% 74.96% +0.01%
- Complexity 935 936 +1
============================================
Files 177 177
Lines 4099 4106 +7
Branches 328 329 +1
============================================
+ Hits 3072 3078 +6
- Misses 874 875 +1
Partials 153 153
Continue to review full report at Codecov.
|
yihanzhen
approved these changes
Dec 27, 2018
Contributor
yihanzhen
left a comment
yihanzhen
left a comment
There was a problem hiding this comment.
LGTM after the nit. @andreamlin @vam-google Do you guys want to take a look?
| * Add a callback that can intercept channel creation. | ||
| * | ||
| * <p>This can be used for advanced configuration like setting the netty event loop. The | ||
| * callback will be invoked with a fully configured channel builder, which can the callback can |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Cool if I merge this? |
Contributor
|
Sure please do! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #573
This introduces a channel configurator function which can be set on a InstantiatingGrpcChannelProvider. It will be invoked right before creating individual channels in the pool.
This is necessary because InstantiatingGrpcChannelProvider creates a few package private classes that users can't instantiate themselves