This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Track overall attempt counts in TimedAttemptSettings #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is extracted from googleapis#613 (comment). Currently for streaming RPCs TimedAttemptSettings only tracks how many attempts occurred trying to receive the next message. Once the message is received, the attempt count is reset. This adds a new field to TimedAttemptSettings that will track overall count so that it can be used in a future integration with opencensus (or be used in a new retry algorithm)
googlebot
added
the
cla: yes
igorbernstein2
changed the title
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
============================================
- Coverage 74.94% 74.93% -0.01%
Complexity 935 935
============================================
Files 177 177
Lines 4099 4102 +3
Branches 328 328
============================================
+ Hits 3072 3074 +2
- Misses 874 875 +1
Partials 153 153
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
============================================
- Coverage 74.94% 74.93% -0.01%
Complexity 935 935
============================================
Files 177 177
Lines 4099 4102 +3
Branches 328 328
============================================
+ Hits 3072 3074 +2
- Misses 874 875 +1
Partials 153 153
Continue to review full report at Codecov.
|
igorbernstein2
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from #613 (comment).
Currently for streaming RPCs TimedAttemptSettings only tracks how many attempts occurred trying to receive the next message. Once the message is received, the attempt count is reset.
This adds a new field to TimedAttemptSettings that will track overall count so that it can be used in a future integration with opencensus (or be used in a new retry algorithm)