Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

@andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Feb 11, 2019

Resolves #661

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2019
@andreamlin
Copy link
Contributor Author

@igorbernstein2 PTAL
Does the opencensus version need to be updated, and to what?

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #663   +/-   ##
=========================================
  Coverage     75.94%   75.94%           
  Complexity     1014     1014           
=========================================
  Files           190      190           
  Lines          4452     4452           
  Branches        346      346           
=========================================
  Hits           3381     3381           
  Misses          915      915           
  Partials        156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ccd85...eb8e509. Read the comment docs.

@igorbernstein2
Copy link
Contributor

You can find grpc's opencensus version here:
https://github.com/grpc/grpc-java/blob/v1.18.0/build.gradle#L115

(it's 0.18.0)

@andreamlin
Copy link
Contributor Author

Ok, updated the opencensus version too.

apply plugin: 'com.github.sherter.google-java-format'
apply plugin: 'io.codearte.nexus-staging'

project.version = "1.38.1-SNAPSHOT" // {x-version-update:gax:current}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops whoops

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2019
@sduskis sduskis added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 12, 2019
@igorbernstein2
Copy link
Contributor

@andreamlin do you mind if I merge this? I need the fix from grpc/grpc-java#5142

@andreamlin andreamlin merged commit 2d7458e into googleapis:master Feb 12, 2019
@andreamlin andreamlin deleted the update_grpc branch February 12, 2019 19:08
@igorbernstein2 igorbernstein2 removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2019
@igorbernstein2
Copy link
Contributor

Thanks!

This was referenced Feb 13, 2019
This was referenced Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants