This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Expose LRO callables for HttpJson #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
PTAL |
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
===========================================
- Coverage 75.63% 75.5% -0.14%
Complexity 1029 1029
===========================================
Files 195 195
Lines 4613 4621 +8
Branches 356 356
===========================================
Hits 3489 3489
- Misses 966 974 +8
Partials 158 158
Continue to review full report at Codecov.
|
vam-google
approved these changes
Feb 22, 2019
| * by generated code. | ||
| * | ||
| * @param httpJsonCallSettings the gRPC call settings | ||
| * @param callSettings the Unary call settings |
Contributor
There was a problem hiding this comment.
Minor: should Unary start with capital letter here?
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
============================================
- Coverage 75.63% 75.51% -0.12%
- Complexity 1029 1030 +1
============================================
Files 195 195
Lines 4613 4616 +3
Branches 356 357 +1
============================================
- Hits 3489 3486 -3
- Misses 966 972 +6
Partials 158 158
Continue to review full report at Codecov.
|
This was referenced Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the HttpJson version of GrpcStubCallableFactory and GrpcCallableFactory.
These new methods will be implemented by future versions of HttpJsonGlobalOperationStubCallableFactory, etc., in the same way that
com.google.longrunning.stub.GrpcOperationsCallableFactoryimplements GrpcStubCallableFactory.