This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Fix Bazel build dependencies #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
=========================================
Coverage 75.46% 75.46%
Complexity 1037 1037
=========================================
Files 196 196
Lines 4675 4675
Branches 363 363
=========================================
Hits 3528 3528
Misses 986 986
Partials 161 161Continue to review full report at Codecov.
|
andreamlin
reviewed
May 10, 2019
repositories.bzl
Outdated
| _protobuf_version = PROPERTIES["version.com_google_protobuf"] | ||
| if _protobuf_version == "3.6.1": | ||
| _protobuf_version = "3.6.1.3" | ||
| _grpc_version_in_link = "v%s" % _protobuf_version |
Contributor
There was a problem hiding this comment.
Why is this named _grpc_version_in_link?
Contributor
Author
There was a problem hiding this comment.
Because it was me doing copy-paste without thinking... Renamed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.