Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 26, 2019

We should prefer an individual timeout configured for the RPC call over the totalTimeout setting for non-retryable RPC calls.

Fixes googleapis/google-cloud-java#5555

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #745 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #745      +/-   ##
============================================
- Coverage     77.72%   77.71%   -0.01%     
- Complexity     1094     1096       +2     
============================================
  Files           198      198              
  Lines          4799     4806       +7     
  Branches        377      379       +2     
============================================
+ Hits           3730     3735       +5     
- Misses          898      899       +1     
- Partials        171      172       +1
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/google/api/gax/rpc/Callables.java 67.85% <66.66%> (+0.51%) 12 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3357c...a1ccea5. Read the comment docs.

@chingor13 chingor13 requested a review from igorbernstein2 June 27, 2019 20:33
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Cloud Tasks Library has breaking changes

3 participants