This repository was archived by the owner on Nov 18, 2025. It is now read-only.
Allow grpc custom channel without auth.#129
Merged
jmuk merged 3 commits intogoogleapis:masterfrom Apr 14, 2017
Merged
Conversation
Fixes #128
Codecov Report
@@ Coverage Diff @@
## master googleapis/gax-nodejs#129 +/- ##
======================================
Coverage 92.3% 92.3%
======================================
Files 11 11
Lines 1300 1300
Branches 267 267
======================================
Hits 1200 1200
Misses 100 100
Continue to review full report at Codecov.
|
landrito
reviewed
Apr 4, 2017
lib/grpc.js
Outdated
| @@ -79,13 +79,27 @@ module.exports = GrpcClient; | |||
| * @param {Object} auth - the authentication object. | |||
| * @return {Object} The gRPC credential object. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
11 tasks
landrito
approved these changes
Apr 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node-core#491