Allow users to pass in headers at method call.#130
Allow users to pass in headers at method call.#130landrito merged 3 commits intogoogleapis:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
=========================================
+ Coverage 92.3% 92.71% +0.4%
=========================================
Files 11 11
Lines 1300 1304 +4
Branches 267 269 +2
=========================================
+ Hits 1200 1209 +9
+ Misses 100 95 -5
Continue to review full report at Codecov.
|
|
Cool, thank you! |
| var headers = otherArgs.headers || {}; | ||
| for (var key in headers) { | ||
| if (headers.hasOwnProperty(key)) { | ||
| metadata.set(key, headers[key]); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jmuk
left a comment
jmuk
left a comment
There was a problem hiding this comment.
LGTM, with a suggestion of adding a test case.
| expect(setSpy.secondCall.args).to.deep.equal(['h2', 'val2']); | ||
| done(); | ||
| }); | ||
| }); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Thank you! Please give me a ping when the new release it out. |
4 participants
cc @stephenplusplus
This should help users set other headers as needed here