feat: API regeneration: release-2026-05-13.08-02-56#3172
Conversation
…onsumerAPI.v1 version 1.74.0.4131
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several Google API discovery documents and their associated generated .NET client libraries, including the addition of the Cloud Number Registry API. Key updates include the addition of SHA512 hash support for media uploads, new metadata and query options for HomeGraph, pickup cost details for Merchant Products, and Cloud Run job support for Network Management. The review feedback identifies formatting errors in documentation strings for Firebase App Hosting and HomeGraph, as well as a type safety improvement for the generated HomeGraph client code.
| }, | ||
| "requiredPaths": { | ||
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\u201d type: GLOB }", | ||
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if both ignored_paths and required_paths are not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\u201d type: GLOB }", |
There was a problem hiding this comment.
The example in the description has incorrect quoting. The closing curly quote (”) is placed immediately after the pattern string instead of at the end of the example block, and there is a mix of escaped straight quotes and curly quotes which makes the example confusing.
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if both ignored_paths and required_paths are not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\u201d type: GLOB }", | |
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if both ignored_paths and required_paths are not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\", type: GLOB }\u201d", |
| }, | ||
| "requiredPaths": { | ||
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\u201d type: GLOB }", | ||
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if both ignored_paths and required_paths are not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\u201d type: GLOB }", |
There was a problem hiding this comment.
The example in the description has incorrect quoting. The closing curly quote (”) is placed immediately after the pattern string instead of at the end of the example block, and there is a mix of escaped straight quotes and curly quotes which makes the example confusing.
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if both ignored_paths and required_paths are not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\u201d type: GLOB }", | |
| "description": "Optional. A list of file paths patterns that trigger a build and rollout if at least one of the changed files in the commit are present in this list. This field is optional; the rollout policy will default to triggering on all paths if both ignored_paths and required_paths are not populated. Limited to 100 paths. Example: \u201crequired_paths: { pattern: \"foo/bar/*\", type: GLOB }\u201d", |
| "additionalProperties": { | ||
| "$ref": "DeviceMetadata" | ||
| }, | ||
| "description": "Map from the Trait ID (e.g., \"action.devices.traits.OnOff\") to its last Spanner commit timestamp. If a trait has no recorded timestamp, it will be omitted from this map.", |
There was a problem hiding this comment.
The description for deviceMetadata appears to be a copy-paste error from DeviceMetadata.traitCommitTimestamps. It describes the map as being from "Trait ID" to "timestamp", but the schema indicates it is a map from Device ID to DeviceMetadata objects.
| "description": "Map from the Trait ID (e.g., \"action.devices.traits.OnOff\") to its last Spanner commit timestamp. If a trait has no recorded timestamp, it will be omitted from this map.", | |
| "description": "Map from the device ID to its metadata. If a device has no recorded metadata, it will be omitted from this map.", |
| /// Map from the Trait ID (e.g., "action.devices.traits.OnOff") to its last Spanner commit timestamp. | ||
| /// </summary> | ||
| [Newtonsoft.Json.JsonPropertyAttribute("traitCommitTimestamps")] | ||
| public virtual System.Collections.Generic.IDictionary<string, object> TraitCommitTimestamps { get; set; } |
There was a problem hiding this comment.
The property TraitCommitTimestamps is generated as IDictionary<string, object>, but the corresponding discovery document specifies the values as string (with google-datetime format). Using string would provide better type safety for the API consumers.
public virtual System.Collections.Generic.IDictionary<string, string> TraitCommitTimestamps { get; set; }2 participants
Changes in this PR will be published to Nuget on the next release cycle.