Skip to content

Remove ClientLogin #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 3 commits into from
Jan 2, 2019
Merged

Remove ClientLogin #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04d3003
Remove ClientLogin
chingor13 Dec 13, 2018
bdc66ca
Bump clirr comparison version and note that we are removing beta classes
chingor13 Dec 13, 2018
e5a04dc
Merge branch 'master' into remove-client-login
chingor13 Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,8 @@
<!-- see http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences.html -->

<differences>
<difference>
<differenceType>8001</differenceType>
<className>com/google/api/client/googleapis/auth/clientlogin/**</className>
</difference>
</differences>
33 changes: 14 additions & 19 deletions findbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,18 @@
<LastVersion value="-1" relOp="NEQ"/>
<!-- The following have not yet been investigated -->

<!-- The following are known to be bugs and should be fixed -->
<And>
<Package name="com.google.api.client.googleapis.auth.clientlogin"/>
</And>

<!-- The following are known to NOT be bugs and should not be fixed -->
<And>
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
<!-- Class doesn't override equals in superclass -->
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
<!-- Class doesn't override equals in superclass -->
<Class name="com.google.api.client.googleapis.auth.oauth2.GoogleAuthorizationCodeRequestUrl"/>
</And>
<And>
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
<Class name="com.google.api.client.googleapis.auth.oauth2.GoogleBrowserClientRequestUrl"/>
</And>
<And>
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
<Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
<Class name="com.google.api.client.googleapis.GoogleUrl"/>
</And>
<And>
Expand Down Expand Up @@ -88,26 +83,26 @@
<And>
<Bug pattern="DM_STRING_CTOR"/>
<!-- Method invokes inefficient new String(String) constructor -->
<Class name="com.google.api.client.googleapis.batch.BatchRequest"/>
</And>
<Class name="com.google.api.client.googleapis.batch.BatchRequest"/>
</And>
<And>
<Bug pattern="DM_STRING_CTOR"/>
<!-- Method invokes inefficient new String(String) constructor -->
<Class name="com.google.api.client.googleapis.services.AbstractGoogleClient"/>
</And>
<Class name="com.google.api.client.googleapis.services.AbstractGoogleClient"/>
</And>
<And>
<Bug pattern="DM_STRING_CTOR"/>
<!-- Method invokes inefficient new String(String) constructor -->
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential"/>
</And>
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential"/>
</And>
<And>
<Bug pattern="DM_STRING_CTOR"/>
<!-- Method invokes inefficient new String(String) constructor -->
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential$RequestHandler"/>
</And>
<Class name="com.google.api.client.googleapis.extensions.android.gms.auth.GoogleAccountCredential$RequestHandler"/>
</And>
<And>
<Bug pattern="DM_STRING_CTOR"/>
<!-- Method invokes inefficient new String(String) constructor -->
<Class name="com.google.api.client.googleapis.xml.atom.MultiKindFeedParser"/>
</And>
<Class name="com.google.api.client.googleapis.xml.atom.MultiKindFeedParser"/>
</And>
</FindBugsFilter>
156 changes: 0 additions & 156 deletions ...t/src/main/java/com/google/api/client/googleapis/auth/clientlogin/AuthKeyValueParser.java
View file
Open in desktop

This file was deleted.

Loading