docs(samples): Talent API Sample Revision & Test

[joecervino]

Fixes #1296

• Tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

[JustinBeckwith]

Thanks! 🎉

[JustinBeckwith]

👋 @JCIV-SE it looks like the sample tests are failing. Can you take a look please?

[joecervino]

@JustinBeckwith Carrying over the outdated duplicate PR's discussion:

• Relevant code in the sample

  const projectId = await google.auth.getProjectId();
  const res = await jobService.projects.companies.create({
    parent: `project/${projectId}`,
    requestBody: {

• Relevant code in the test

    const scope = nock(Utils.baseUrl)
                      .post(`/v3/jobs/project/project-id/companies`)
                      .reply(200, {});
    const data = await samples.jobs.runSample();

I'm mirroring a lot of the code from other samples. The biggest difference is the url passed to .post() in the test where I hard-code the project-id to the one used for testing in the repo. Using a template literal + project-id variable doesn't work well there. The company creation method constructs the url to access the company directly using the parent property and the request body properties - do you think it has to do with that? I'm new to Nock so the nuances aren't readily apparent yet :)

[JustinBeckwith]

🤷‍♂️ If you can push to a branch on upstream, I can clone it and take a look :)

[joecervino]

@JustinBeckwith Don't have access to the upstream repo like that :l you can clone the forked branch here: https://github.com/JCIV-SE/google-api-nodejs-client/tree/samples/talentapi

[JustinBeckwith]

@JCIV-SE I just invited you to the googleapis org. Let me know when you accept, and I can get you added to the correct groups.

[JustinBeckwith]

Ah! I think this is the problem. For this url, can you use ${process.env.GCLOUD_PROJECT}?

[joecervino]

Good idea! I tried it several different ways though and I'm still getting:

FetchError: request to https://jobs.googleapis.com/v3/project/project-id/companies failed, 
reason: Nock: Disallowed net connect for "jobs.googleapis.com:443/v3/project/project-id/companies"

🎊

I accepted the invitation (thanks!), I'll try pushing a branch upstream once auth allows it

[JustinBeckwith]

huh weird. Share your updated code?

[joecervino]

Sure! Here's version 1:

  it('should create a company', async () => {
    const scope = nock(Utils.baseUrl)
                      .post(`/v3/jobs/project/${process.env.GCLOUD_PROJECT}/companies`)

version 2:

  it('should create a company', async () => {
    const scope = nock(Utils.baseUrl)
                      .post(`${process.env.GCLOUD_PROJECT}`)

I tried a few other ways but the above two are the ones that make sense

[JustinBeckwith]

Huh, v1 looks right to me

[joecervino]

Some logging revealed that GCLOUD_PROJECT is undefined until we go into runSample's scope where we call on the auth service to generate a project Id - copying the same code ( const projectId = await google.auth.getProjectId();) into the test's scope gives us undefined too so.. any chance we can erase this test and push the sample up anyway? A bit anarchistic but I noticed there are a few other APIs without them

[JustinBeckwith]

Keep the test, just put a .skip on it :)

[joecervino]

Cool! Done!