Deserialize type: Date values #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
TheRoyalTnetennba
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
TheRoyalTnetennba
approved these changes
May 10, 2019
blowmage
approved these changes
May 10, 2019
Contributor
blowmage
left a comment
blowmage
left a comment
There was a problem hiding this comment.
I'm cautiously approving. I worry about unintended consequences here, but I also don't see a reason not to fix this behavior.
Member
|
As @blowmage feared, this change led to unit test failures in google-cloud-storage (fixed in googleapis/google-cloud-ruby#3417). |
Contributor
|
The joys of using a library that has never reached 1.0... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://www.rubydoc.info/github/google/google-api-ruby-client/Google/Apis/CalendarV3/EventDateTime#date-instance_method the
dateshould be parsed to aDate, but currently it is only a "yyyy-mm-dd" string.