Skip to content

createScoped: fix endless recursion #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Mar 25, 2019
Merged

createScoped: fix endless recursion #229

sduskis merged 1 commit into from
Mar 25, 2019

Conversation

@danielnorberg
Copy link
Contributor

@danielnorberg danielnorberg commented Mar 5, 2019

Call createScoped implementation instead of endlessly recursing.

createScoped: make overload call implementation
67aa926 
Call `createScoped` implementation instead of endlessly recursing.
@danielnorberg danielnorberg requested a review from a team as a code owner March 5, 2019 07:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 5, 2019
@danielnorberg danielnorberg changed the title createScoped: make overload call implementation createScoped: fix endless recursion Mar 5, 2019
@sduskis
Copy link
Contributor

sduskis commented Mar 5, 2019

yikes. Thanks for finding this.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 12, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 25, 2019
@codecov
Copy link

codecov bot commented Mar 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@44a5d33). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #229   +/-   ##
=========================================
  Coverage          ?   78.33%           
  Complexity        ?      330           
=========================================
  Files             ?       21           
  Lines             ?     1445           
  Branches          ?      158           
=========================================
  Hits              ?     1132           
  Misses            ?      235           
  Partials          ?       78
Impacted Files Coverage Δ Complexity Δ
...java/com/google/auth/oauth2/GoogleCredentials.java 55.55% <100%> (ø) 8 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a5d33...67aa926. Read the comment docs.

@sduskis sduskis merged commit 6698b3f into googleapis:master Mar 25, 2019
@kolea2 kolea2 mentioned this pull request Mar 27, 2019
Merged
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielnorberg @sduskis @googlebot @kokoro-team @yoshi-automation