chore: improve metadata service error handling #1902
Conversation
Distinguish between retry exhaustion due to exceptions and retry exhaustion due to retryable status codes. - Use `last_exception` to track the most recent exception. - Clear `last_exception` on successful response (even if status is retryable). - Raise TransportError chained from `last_exception` if available. - Otherwise raise TransportError with response status and details. - Update tests to match new error format.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Improved error handling in
google/auth/compute_engine/_metadata.pyto provide more informative error messages when retries are exhausted. The code now differentiates between cases where retries failed due to exceptions (e.g., connection errors) vs. retryable HTTP status codes (e.g., 500, 503). This addresses feedback from PR 1637.PR created automatically by Jules for task 6226991344715693997 started by @chalmerlowe