docs: update urllib3 docstrings for v2 compatibility #1903
Conversation
The `urllib3.request` module was removed in urllib3 v2.0.0, and `RequestMethods` was moved to a private module `urllib3._request_methods`. This commit updates the docstrings in `google/auth/transport/urllib3.py` to remove references to the now-private `urllib3.request.RequestMethods` class. Instead, it references the public `urllib3.PoolManager` class or the generic request interface, ensuring the documentation remains accurate for both urllib3 v1 and v2 users. This addresses the documentation aspect of PR #1290.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
3 participants
Updates docstrings in
google/auth/transport/urllib3.pyto referenceurllib3.PoolManagerinstead of the removed/privateurllib3.request.RequestMethods, ensuring compatibility withurllib3v2 documentation standards.NOTE: This PR supercedes an older PR #1290, because some of the content or suggested changes in the older PR are overtaken by events and/or been incorporated via other recent PRs.
PR created automatically by Jules for task 17649723998293325458 started by @chalmerlowe