Skip to content

fix: make ThreadPoolExecutor a class var #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 5 commits into from
Mar 19, 2020
Merged

fix: make ThreadPoolExecutor a class var #461

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d624995
fix: make threadpool clas var
busunkim96 Mar 16, 2020
c882032
fix: set max_workers
busunkim96 Mar 19, 2020
a00f488
Merge branch 'master' into use-class-var
busunkim96 Mar 19, 2020
97e7826
chore: add no cover for py2 branch
busunkim96 Mar 19, 2020
1b49e0f
Merge branch 'master' into use-class-var
busunkim96 Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions google/auth/transport/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,22 @@ class AuthMetadataPlugin(grpc.AuthMetadataPlugin):
object used to refresh credentials as needed.
"""

# Python 2.7 has no default for max_workers.
# In Python >= 3.5, ThreadPoolExecutor defaults to the
# number of processors on the machine, multiplied by 5.
if six.PY2: # pragma: NO COVER
max_workers = 5
else:
max_workers = None
_AUTH_THREAD_POOL = futures.ThreadPoolExecutor(max_workers=max_workers)

def __init__(self, credentials, request):
# pylint: disable=no-value-for-parameter
# pylint doesn't realize that the super method takes no arguments
# because this class is the same name as the superclass.
super(AuthMetadataPlugin, self).__init__()
self._credentials = credentials
self._request = request
self._pool = futures.ThreadPoolExecutor(max_workers=1)

def _get_authorization_headers(self, context):
"""Gets the authorization headers for a request.
Expand Down Expand Up @@ -89,12 +97,9 @@ def __call__(self, context, callback):
callback (grpc.AuthMetadataPluginCallback): The callback that will
be invoked to pass in the authorization metadata.
"""
future = self._pool.submit(self._get_authorization_headers, context)
future = self._AUTH_THREAD_POOL.submit(self._get_authorization_headers, context)
future.add_done_callback(self._callback_wrapper(callback))

def __del__(self):
self._pool.shutdown(wait=False)


def secure_authorized_channel(
credentials,
Expand Down