feat(GCS+gRPC): more efficient CRC32C computations#11070
Merged
coryan merged 1 commit intoMar 21, 2023
Conversation
Move the CRC32C and MD5 computations to the `GrpcClient` and `RestClient`. In the case of gRPC this allows us to compute the CRC32C checksum for each `Write()` message and then concatenate this checksum with the CRC32C checksum computed for the full object. That saves one of the most expensive computations in the gRPC uploads.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #11070 +/- ##
==========================================
- Coverage 93.76% 93.76% -0.01%
==========================================
Files 1730 1730
Lines 156241 156319 +78
==========================================
+ Hits 146504 146573 +69
- Misses 9737 9746 +9
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the CRC32C and MD5 computations to the
GrpcClientandRestClient. In the case of gRPC this allows us to compute the CRC32C checksum for eachWrite()message and then concatenate this checksum with the CRC32C checksum computed for the full object. That saves one of the most expensive computations in the gRPC uploads.Fixes #11060
This change is