Skip to content

cleanup(generator): make static variable trivially destructible #14599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuiy0006 merged 1 commit into from
Jul 31, 2024
Merged

cleanup(generator): make static variable trivially destructible #14599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generator/internal/http_option_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,9 @@ std::string FormatApiVersionFromPackageName(
std::string FormatApiVersionFromUrlPattern(std::string const& url_pattern,
std::string const& file_name) {
std::vector<std::string> parts = absl::StrSplit(url_pattern, '/');
static std::regex const kRe{R"(v\d+)"};
static auto const* const kVersion = new std::regex{R"(v\d+)"};
for (auto const& part : parts) {
if (std::regex_match(part, kRe)) {
if (std::regex_match(part, *kVersion)) {
return part;
}
}
Expand Down