Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 9, 2024

Backport #14615 and #14617 to the v2.25.x branch, preparing for v2.25.1.

Description of changes from @scotthart:

For a Patch, Post, or Put request, curl_multi_perform should result in all the data from the associated WriteVector being consumed before it returns. Except in the case of a timeout, in which case we do not want libcurl to attempt to transmit the rest of the data while we read any remaining response data to populate the Status error message.

No need to update the ABI dumps as no public symbols have changed, and we only encode the major and minor versions in the inline namespace.


This change is Reviewable

@dbolduc dbolduc added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2024
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2024
@dbolduc dbolduc marked this pull request as ready for review August 9, 2024 19:11
@dbolduc dbolduc requested a review from a team as a code owner August 9, 2024 19:11
@codecov
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2.25.x@aaf88be). Learn more about missing BASE report.

Files with missing lines Patch % Lines
google/cloud/internal/curl_impl.cc 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v2.25.x   #14626   +/-   ##
==========================================
  Coverage           ?   93.77%           
==========================================
  Files              ?     2268           
  Lines              ?   201861           
  Branches           ?        0           
==========================================
  Hits               ?   189297           
  Misses             ?    12564           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit 567d8f2 into googleapis:v2.25.x Aug 9, 2024
@dbolduc dbolduc deleted the my-patch branch August 9, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants