-
Notifications
You must be signed in to change notification settings - Fork 436
fix(storage): make notification, hmac, service account ops return unimplemented in gRPC #14742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): make notification, hmac, service account ops return unimplemented in gRPC #14742
Conversation
468e0b6 to
da14840
Compare
scotthart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @ddelgrosso1)
google/cloud/storage/internal/grpc/stub.cc line 973 at r1 (raw file):
rest_internal::RestContext&, Options const&, storage::internal::GetProjectServiceAccountRequest const&) { return Status(StatusCode::kUnimplemented, "");
If these rpcs are available in storagecontrol, would it be useful for the for the error message to indicate such?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14742 +/- ##
==========================================
- Coverage 93.45% 93.42% -0.03%
==========================================
Files 2323 2314 -9
Lines 208152 207591 -561
==========================================
- Hits 194529 193945 -584
- Misses 13623 13646 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddelgrosso1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 24 files reviewed, 1 unresolved discussion (waiting on @scotthart)
google/cloud/storage/internal/grpc/stub.cc line 973 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
If these rpcs are available in storagecontrol, would it be useful for the for the error message to indicate such?
They aren't yet available in storage control but I will add myself a followup issue to update these messages once they become available.
scotthart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddelgrosso1)
Fixes: #14396
This change is