ci(v3): skip gcs prod tests creating public buckets

[mpeddada1]

Porting changes for #15855

[gemini-code-assist]

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of Spanner integration tests by accommodating kUnimplemented status for optimistic locking, and temporarily disables specific Google Cloud Storage integration tests that interact with public buckets or IAM policies in non-emulator environments. The latter change serves as a workaround for an identified issue, preventing failures in continuous integration pipelines.

Highlights

• Spanner Integration Test Robustness: Updated the ReadLockModeOptionIsSent test in Spanner integration tests to gracefully handle kUnimplemented status codes for optimistic lock operations, ensuring the test passes even if the feature is not enabled in the environment.
• Temporary Skipping of GCS Public Bucket Tests: Introduced GTEST_SKIP() for several Google Cloud Storage integration tests that involve creating public buckets or modifying IAM policies, specifically when these tests are not running against an emulator. This is a temporary measure to address an existing issue (Fix test bucket creation for prod tests #15854).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request ports changes from another PR, with the main goal of skipping GCS production tests that create public buckets. This is done by either commenting out example code or using GTEST_SKIP() in test files, conditioned on whether the test is running against the emulator. The changes are correct and align with the goal of the PR. I have one suggestion to improve the clarity of a disabled example by using a conditional block instead of commented-out code. Additionally, a change in a Spanner integration test is included, which makes the test more robust by handling cases where a feature is not implemented, which is a good improvement.

[gemini-code-assist]

To make the intent clearer and align with the approach in other test files, consider using a conditional check against the emulator instead of commenting out the code. This also reduces the chance of this code being overlooked in the future. Printing a message about skipping the test would also be helpful for visibility.

  // TODO(#15854): Enable this test when the issue is resolved.
  if (examples::UsingEmulator()) {
    std::cout << "\nRunning NativeSetBucketPublicIam() example" << std::endl;
    NativeSetBucketPublicIam(client, {bucket_name});
  } else {
    std::cout << "\nSkipping NativeSetBucketPublicIam() example against production." << std::endl;
  }

[scotthart]

/gcbrun

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (ef3b199) to head (9e3cefa).
⚠️ Report is 3 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15860      +/-   ##
======================================================
- Coverage               92.87%   92.86%   -0.01%     
======================================================
  Files                    2422     2422              
  Lines                  223243   223248       +5     
======================================================
- Hits                   207328   207316      -12     
- Misses                  15915    15932      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.