Skip to content

doc(spanner): convert Spanner samples to use the generated admin APIs#7311

Merged
devbww merged 2 commits intogoogleapis:mainfrom
devbww:sample-migration
Sep 14, 2021
Merged

doc(spanner): convert Spanner samples to use the generated admin APIs#7311
devbww merged 2 commits intogoogleapis:mainfrom
devbww:sample-migration

Conversation

@devbww
Copy link
Contributor

@devbww devbww commented Sep 14, 2021

This change is Reviewable

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Sep 14, 2021
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 14, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3c36c3cd455bc8e766ec701b78240b8772e64fa5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #7311 (bbab073) into main (480cd16) will decrease coverage by 0.03%.
The diff coverage is 40.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7311      +/-   ##
==========================================
- Coverage   93.69%   93.65%   -0.04%     
==========================================
  Files        1347     1349       +2     
  Lines      116534   116605      +71     
==========================================
+ Hits       109185   109207      +22     
- Misses       7349     7398      +49     
Impacted Files Coverage Δ
google/cloud/spanner/samples/samples.cc 62.83% <40.46%> (-0.62%) ⬇️
google/cloud/spanner/instance_admin_connection.cc 91.87% <0.00%> (-4.38%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.00% <0.00%> (-0.60%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.78% <0.00%> (-0.25%) ⬇️
google/cloud/spanner/admin/database_admin_client.h 50.00% <0.00%> (ø)
google/cloud/spanner/admin/instance_admin_client.h 50.00% <0.00%> (ø)
google/cloud/pubsub/samples/samples.cc 92.04% <0.00%> (+0.07%) ⬆️
google/cloud/grpc_error_delegate.cc 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480cd16...bbab073. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: bbab073546c7dc98f48b8fd10fc7023ea63cbd5b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@devbww devbww marked this pull request as ready for review September 14, 2021 20:22
@devbww devbww requested a review from a team as a code owner September 14, 2021 20:22
@devbww devbww merged commit b6dd0b1 into googleapis:main Sep 14, 2021
@devbww devbww deleted the sample-migration branch September 14, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants