fix(storage): use correct offset and size types #8538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct types of stream offsets (`std::streamoff`) vs. stream buffer sizes (`std::streamsize`). Cleanup some uses of `std::uintmax_t` where `std::int64_t` is more reasonable.
product-auto-label
bot
added
the
api: storage
Collaborator
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8538 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 1453 1453
Lines 125885 125885
=======================================
+ Hits 118237 118240 +3
+ Misses 7648 7645 -3
Continue to review full report at Codecov.
|
Contributor
Author
|
Manually tested on Windows+x86 and @ahnjs1987 reports this works on ARM32 too. |
devjgm
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct types of stream offsets (
std::streamoff) vs.stream buffer sizes (
std::streamsize). Cleanup some uses ofstd::uintmax_twherestd::int64_tis more reasonable.Fixes #8536
This change is