fix: retry PDML on EOS on DATA error #5238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
For long-running PDML queries (>= 30mins), there's a possibility that the gRPC connection is terminated with an error "Received unexpected EOS on DATA frame from server". We now retry the same transaction on this error. Fixes googleapis#5209
skuruppu
force-pushed
the
spanner-retry-on-eos
branch
from
557da96 to
16fb474
Compare
jskeet
approved these changes
Sep 2, 2020
Contributor
Author
|
Thanks for the quick review @jskeet. @thiagotnunes are you able to checkout out this branch and run your test? You can use the Docker container by following the instructions here. Happy to chat more about it tomorrow. If you don't have the cycles, all good as well. I will try to do it next week. |
|
@skuruppu the test completed successfully, thanks for the fix! |
Contributor
Author
|
Woohoo thanks for verifying the fix @thiagotnunes 🙇♀️ |
jskeet
added a commit
to jskeet/google-cloud-dotnet
that referenced
this pull request
Sep 10, 2020
Changes since 3.1.0: - [Commit 0272d4e](googleapis@0272d4e): fix: retry PDML on EOS on DATA error ([issue 5238](googleapis#5238)) - [Commit b43315c](googleapis@b43315c): feat: add NUMERIC support ([issue 5057](googleapis#5057))
jskeet
added a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For long-running PDML queries (>= 30mins), there's a possibility that the gRPC connection is terminated with an error "Received unexpected EOS on DATA frame from server".
We now retry the same transaction on this error.
Fixes #5209