Skip to content

Add of() method to DatasetInfo #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mziccard merged 1 commit into from
Sep 21, 2016
Merged

Add of() method to DatasetInfo #1275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,20 @@ public static Builder builder(String datasetId) {
return builder(DatasetId.of(datasetId));
}

/**
* Returns a {@code DatasetInfo} object given it's identity.
*/
public static DatasetInfo of(DatasetId datasetId) {
return builder(datasetId).build();
}

/**
* Returns a {@code DatasetInfo} object given it's user-defined id.
*/
public static DatasetInfo of(String datasetId) {
return builder(datasetId).build();
}

/**
* Returns a builder for the DatasetInfo object given it's user-defined project and dataset ids.
*/
Expand Down
28 changes: 28 additions & 0 deletions google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/DatasetInfoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,34 @@ public void testBuilder() {
assertEquals(SELF_LINK, DATASET_INFO_COMPLETE.selfLink());
}

@Test
public void testOf() {
DatasetInfo datasetInfo = DatasetInfo.of(DATASET_ID.dataset());
assertEquals(DATASET_ID, datasetInfo.datasetId());
assertNull(datasetInfo.acl());
assertNull(datasetInfo.creationTime());
assertNull(datasetInfo.defaultTableLifetime());
assertNull(datasetInfo.description());
assertNull(datasetInfo.etag());
assertNull(datasetInfo.friendlyName());
assertNull(datasetInfo.generatedId());
assertNull(datasetInfo.lastModified());
assertNull(datasetInfo.location());
assertNull(datasetInfo.selfLink());
datasetInfo = DatasetInfo.of(DATASET_ID);
assertEquals(DATASET_ID, datasetInfo.datasetId());
assertNull(datasetInfo.acl());
assertNull(datasetInfo.creationTime());
assertNull(datasetInfo.defaultTableLifetime());
assertNull(datasetInfo.description());
assertNull(datasetInfo.etag());
assertNull(datasetInfo.friendlyName());
assertNull(datasetInfo.generatedId());
assertNull(datasetInfo.lastModified());
assertNull(datasetInfo.location());
assertNull(datasetInfo.selfLink());
}

@Test
public void testToPbAndFromPb() {
compareDatasets(DATASET_INFO_COMPLETE, DatasetInfo.fromPb(DATASET_INFO_COMPLETE.toPb()));
Expand Down