Skip to content

Fixing warn log message #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pongad merged 5 commits into from
Mar 11, 2018
Merged

Fixing warn log message #3011

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d369d57
Fixing warn log message
pgbhagat Mar 8, 2018
6af541e
Code review comment, avoiding String.format while logging
pgbhagat Mar 9, 2018
980cedb
Code review comment
pgbhagat Mar 9, 2018
cd2e7aa
Code review
pgbhagat Mar 9, 2018
5869582
Check in to trigger a build
pgbhagat Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions google-cloud-translate/src/main/java/com/google/cloud/translate/TranslateOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,30 +155,28 @@ private TranslateOptions(Builder builder) {
apiKey = null;
if (builder.apiKey != null) {
logger.log(
Level.WARNING, "Ignoring API key: using explicit setting for credentials instead.");
Level.WARNING,
"Ignoring API key: using explicit setting for credentials instead.");
} else if (getDefaultApiKey() != null) {
logger.log(
Level.WARNING,
String.format(
"Ignoring API key set in environment variable %s: using explicit setting for credentials instead.",
API_KEY_ENV_NAME));
"Ignoring API key set in environment variable {0}: using explicit setting for credentials instead.",
API_KEY_ENV_NAME);
}
} else if (builder.apiKey != null) {
credentials = null;
apiKey = builder.apiKey;
logger.log(
Level.WARNING,
String.format(
"Ignoring Application Default Credentials: using explicit setting for API key instead.",

This comment was marked as spam.

Sign in to view

ServiceOptions.CREDENTIAL_ENV_NAME));
"Ignoring Application Default Credentials {0}: using explicit setting for API key instead.",
ServiceOptions.CREDENTIAL_ENV_NAME);
} else if (credentials != null) { // credentials assigned from ADC in superclass constructor
apiKey = null;
if (getDefaultApiKey() != null) {
logger.log(
Level.WARNING,
String.format(
"Ignoring API key set in environment variable %s: using Application Default Credentials instead.",
API_KEY_ENV_NAME));
"Ignoring API key set in environment variable {0}: using Application Default Credentials instead.",
API_KEY_ENV_NAME);
}
} else {
apiKey = getDefaultApiKey();
Expand Down