Skip to content

Adding Query Tests for NaN and Null #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schmidt-sebastian merged 1 commit into from
Mar 28, 2018
Merged

Adding Query Tests for NaN and Null #3091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions google-cloud-firestore/src/test/java/com/google/cloud/firestore/ConformanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,8 @@ private Object convertValue(Object data) {
return convertMap((Map<String, Object>) data);
} else if (data instanceof List) {
return convertArray((List<Object>) data);
} else if ("NaN".equals(data)) {
return Double.NaN;
} else if ("Delete".equals(data)) {
return FieldValue.delete();
} else if ("ServerTimestamp".equals(data)) {
Expand Down
Binary file modified google-cloud-firestore/src/test/resources/test-suite.binproto
View file
Open in desktop
Binary file not shown.