Skip to content

internal: improve pubsub javadoc #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeanbza merged 2 commits into from
Apr 9, 2018
Merged

internal: improve pubsub javadoc #3132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
696e745
internal: improve pubsub javadoc
jeanbza Apr 6, 2018
b197126
Fix compilation errors, add executor pool shutdown
jeanbza Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ...-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/SubscriberSnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
import com.google.cloud.pubsub.v1.AckReplyConsumer;
import com.google.cloud.pubsub.v1.MessageReceiver;
import com.google.cloud.pubsub.v1.Subscriber;
import com.google.cloud.pubsub.v1.stub.SubscriberStubSettings;
import com.google.cloud.pubsub.v1.stub.GrpcSubscriberStub;
import com.google.cloud.pubsub.v1.stub.SubscriberStub;
import com.google.cloud.pubsub.v1.stub.SubscriberStubSettings;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.pubsub.v1.AcknowledgeRequest;
import com.google.pubsub.v1.ProjectSubscriptionName;
Expand All @@ -45,7 +45,8 @@
import java.io.FileInputStream;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.Executor;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;

/** This class contains snippets for the {@link Subscriber} interface. */
public class SubscriberSnippets {
Expand All @@ -56,29 +57,26 @@ public class SubscriberSnippets {

private final ApiFuture<Void> done;

private final Executor executor;

public SubscriberSnippets(
ProjectSubscriptionName subscriptionName,
MessageReceiver receiver,
ApiFuture<Void> done,
Executor executor) {
ApiFuture<Void> done) {
this.subscriptionName = subscriptionName;
this.receiver = receiver;
this.done = done;
this.executor = executor;
}

// [TARGET startAsync()]
public void startAndWait() throws Exception {
Subscriber subscriber = Subscriber.newBuilder(subscriptionName, receiver).build();
ExecutorService pool = Executors.newCachedThreadPool();
subscriber.addListener(
new Subscriber.Listener() {
public void failed(Subscriber.State from, Throwable failure) {
// Handle error.
}
},
executor);
pool);
subscriber.startAsync();

// Wait for a stop signal.
Expand All @@ -97,6 +95,7 @@ public void failed(Subscriber.State from, Throwable failure) {
// }
// at the end of main() to previent the main thread from exiting.
done.get();
pool.shutdown();
subscriber.stopAsync().awaitTerminated();
}

Expand Down
3 changes: 1 addition & 2 deletions ...ud-examples/src/test/java/com/google/cloud/examples/pubsub/snippets/ITPubSubSnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ public void onFailure(Throwable t) {
new SubscriberSnippets(
subscriptionName,
new MessageReceiverSnippets(queue).messageReceiver(),
done,
MoreExecutors.directExecutor());
done);
new Thread(
new Runnable() {
@Override
Expand Down