Skip to content

pubsub: remove TODO #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pongad merged 2 commits into from
Oct 24, 2018
Merged

pubsub: remove TODO #3845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a9fe7d
pubsub: remove TODO
pongad Oct 23, 2018
1d91d41
Merge branch 'master' into pongad-patch-1
pongad Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...ients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,9 +349,8 @@ public void processReceivedMessages(List<ReceivedMessage> messages, Runnable don
// putIfAbsent puts ackHandler if ackID isn't previously mapped, then return the previously-mapped element.
// If the previous element is not null, we already have the message and the new one is definitely a duplicate.
// Don't nack this, because that'd also nack the one we already have in queue.

// TODO(pongad): We could update the total expiration time, but I'm not 100% sure how that plays with
// various resources. Think about this more.
// Don't update the existing one's total expiration either. If the user "loses" the message, we want to eventually
// totally expire so that pubsub service sends us the message again.
continue;
}
outstandingBatch.addMessage(message, ackHandler);
Expand Down