Skip to content

update to api-common 1.8.1 #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 5 commits into from
Apr 26, 2019
Merged

update to api-common 1.8.1 #5015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6961b20
api-common 1.8.0
elharo Apr 25, 2019
bf58f8e
more version updates
Apr 25, 2019
b5ba769
more version updates
Apr 25, 2019
b0b08e4
more version updates
Apr 25, 2019
34bb3c9
api-common 1.8.1
Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google-api-grpc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>3.7.0</version>
<version>3.7.1</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
Expand All @@ -121,7 +121,7 @@
<dependency>
<groupId>com.google.api</groupId>
<artifactId>api-common</artifactId>
<version>1.7.0</version>
<version>1.8.1</version>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
<dependency>
<groupId>com.google.api</groupId>
<artifactId>api-common</artifactId>
<version>1.7.0</version>
<version>1.8.1</version>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
Expand Down
4 changes: 2 additions & 2 deletions google-cloud-clients/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,14 @@
<api-client.version>1.27.0</api-client.version>
<!-- make sure to keep gax version in sync with google-cloud-bom -->
<gax.version>1.44.0</gax.version>
<api.common.java.version>1.7.0</api.common.java.version>
<api.common.java.version>1.8.1</api.common.java.version>
<google.auth.version>0.15.0</google.auth.version>
<grpc.version>1.19.0</grpc.version>
<!-- We are currently using the *-android version to support JDK7. -->
<guava.version>27.1-android</guava.version>
<http-client-bom.version>1.29.0</http-client-bom.version>
<oauth-client.version>1.28.0</oauth-client.version>
<protobuf.version>3.7.0</protobuf.version>
<protobuf.version>3.7.1</protobuf.version>
Copy link
Contributor

@sduskis sduskis Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.. grpc is still on 3.6.1 as of their 1.19.0 release. grpc 1.20.0 upgraded protobuf to 3.7.1. I think that we ought to upgrade grpc as well, and probably opencensus to 0.19.2

Copy link
Contributor Author

@elharo elharo Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense. Not sure any of this is going to work though. There's a dependency-convergence error in google-cloud-core. Probably have to push api-common 1.8.1 and try again to fix that.

Copy link
Contributor

@andreamlin andreamlin Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8.1 is out for api-common-java

Copy link
Contributor Author

@elharo elharo Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgraded to 1.8.1; testing now

Copy link
Contributor Author

@elharo elharo Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ERROR] Errors:
[ERROR] com.google.cloud.datastore.DatastoreTest.com.google.cloud.datastore.DatastoreTest
[ERROR] Run 1: DatastoreTest.beforeClass:157 » IllegalArgument Invalid version format
[ERROR] Run 2: DatastoreTest.afterClass:179 » Connect Connection refused (Connection refused)
[INFO]
[ERROR] LocalDatastoreHelperTest.testStartStopReset:94 » IllegalArgument Invalid versi...
[INFO]
[ERROR] Tests run: 168, Failures: 0, Errors: 2, Skipped: 0
[INFO]

<!-- make sure to keep opencensus version in sync with grpc -->
<opencensus.version>0.19.2</opencensus.version>
<!-- test dependency versions -->
Expand Down