Split javadocs #5019
Closed
Split javadocs #5019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
added
do not merge
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5019 +/- ##
============================================
+ Coverage 50.32% 50.32% +<.01%
+ Complexity 23680 23673 -7
============================================
Files 2238 2238
Lines 226060 226060
Branches 24955 24959 +4
============================================
+ Hits 113766 113768 +2
+ Misses 103689 103688 -1
+ Partials 8605 8604 -1
Continue to review full report at Codecov.
|
sduskis
approved these changes
Apr 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #5019 +/- ##
=========================================
Coverage 50.4% 50.4%
- Complexity 23785 23800 +15
=========================================
Files 2251 2251
Lines 226791 226791
Branches 24966 24961 -5
=========================================
Hits 114320 114320
Misses 103864 103864
Partials 8607 8607Continue to review full report at Codecov.
|
igorbernstein2
added a commit
to igorbernstein2/google-cloud-java
that referenced
this pull request
Apr 29, 2019
Ideally this should be done via a custom doclet that would filter out any classes annotated with `@InternalOnly`, but this doesn't currently exist. Please note that the exclusion are duplicated across google-cloud-clients/pom.xml and google-cloud-bigtable/pom.xml to support the Jeff's work on splitting javadocs into multiple sites (googleapis#5019)
igorbernstein2
added a commit
that referenced
this pull request
Apr 29, 2019
) Ideally this should be done via a custom doclet that would filter out any classes annotated with `@InternalOnly`, but this doesn't currently exist. Please note that the exclusion are duplicated across google-cloud-clients/pom.xml and google-cloud-bigtable/pom.xml to support the Jeff's work on splitting javadocs into multiple sites (#5019)
Contributor
|
@chingor13, this PR is a bit stale. |
Contributor
Author
|
I think reorganizing the clients will supersede this PR. |
chingor13
pushed a commit
to googleapis/java-bigtable
that referenced
this pull request
Sep 26, 2019
…035) Ideally this should be done via a custom doclet that would filter out any classes annotated with `@InternalOnly`, but this doesn't currently exist. Please note that the exclusion are duplicated across google-cloud-clients/pom.xml and google-cloud-bigtable/pom.xml to support the Jeff's work on splitting javadocs into multiple sites (googleapis/google-cloud-java#5019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the javadoc generation into per-artifact minisites. The publish_javadoc kokoro job will now publish each artifact's javadocs separately (and fix linking between all the javadoc sites).
This is not compatible with our current format of aggregating the javadocs into google-api-grpc and google-cloud-clients javadocs. The resulting docs should be better targeted and more usable.