Bigtable: fix integration tests #5762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get integration tests running again. It seems like they were accidentally turned off at some point. Unfortunately it seems like dropRowRange was broken while the integration tests were disabled. I'm working on getting dropRowRange working again, but for now I've disabled the test so that others can start running again. Changes: * use junit47 provider so that parallelism params are respected * update listTables & listTablesAsync tests to use different tables, otherwise the second one times out while awaiting the old table to be deleted asynchronously * show full stack traces when tests fail * temporarily ignore broken dropRowRanges failure
igorbernstein2
added
type: bug
googlebot
added
the
cla: yes
igorbernstein2
added a commit
to igorbernstein2/google-cloud-java
that referenced
this pull request
Jul 18, 2019
igorbernstein2
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
approved these changes
Jul 18, 2019
igorbernstein2
added a commit
that referenced
this pull request
Jul 19, 2019
* Bigtable: Add ability to run tests against direct path * Reorganize failsafe config to have a separate execution for each test integration test target * Move each test integration target into it's own profile (keeping the emulator tests on by default) * Fork the ProdEnv for direct path environment * update docs * cherrypick #5762 * include port in const * fix emulator system prop * make sure to download emulator before running the bigtable integration tests * fix kokoro cmd line * fix continuous & nightly jobs as well * wrokaround flakes due to jdk bug
chingor13
pushed a commit
to googleapis/java-bigtable
that referenced
this pull request
Sep 26, 2019
* Bigtable: Add ability to run tests against direct path * Reorganize failsafe config to have a separate execution for each test integration test target * Move each test integration target into it's own profile (keeping the emulator tests on by default) * Fork the ProdEnv for direct path environment * update docs * cherrypick googleapis/google-cloud-java#5762 * include port in const * fix emulator system prop * make sure to download emulator before running the bigtable integration tests * fix kokoro cmd line * fix continuous & nightly jobs as well * wrokaround flakes due to jdk bug
chingor13
pushed a commit
to googleapis/java-gcloud-maven-plugin
that referenced
this pull request
Oct 7, 2019
* Bigtable: Add ability to run tests against direct path * Reorganize failsafe config to have a separate execution for each test integration test target * Move each test integration target into it's own profile (keeping the emulator tests on by default) * Fork the ProdEnv for direct path environment * update docs * cherrypick googleapis/google-cloud-java#5762 * include port in const * fix emulator system prop * make sure to download emulator before running the bigtable integration tests * fix kokoro cmd line * fix continuous & nightly jobs as well * wrokaround flakes due to jdk bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get integration tests running again. It seems like they were accidentally turned off at some point.
Unfortunately it seems like dropRowRange was broken while the integration tests were disabled.
I'm working on getting dropRowRange working again, but for now I've disabled the test so that others can start running again.
Changes:
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)