datastore.get() with > 300 keys fails

[stephenplusplus]

Moved from here: #1205 (comment), originally reported by @sfbaltaci

Steps to reproduce

var gcd = require('google-cloud').datastore(/* auth here if necessary */)

var keys = []

// var numKeysToCreate = 300 // works
var numKeysToCreate = 350 // fails

while (numKeysToCreate--) {
  keys.push(gcd.key(['Kind', numKeysToCreate + 1]))
}

gcd.get(keys, console.log)

prints an error:

/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2440
                            throw Error(this+"#"+keyOrObj+" is not a field: undefined");
                            ^

Error: .google.datastore.v1beta3.Key#id is not a field: undefined
    at Error (native)
    at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2440:35)
    at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2434:38)
    at Message (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2363:34)
    at ProtoBuf.Reflect.ElementPrototype.verifyValue (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:1877:28)
    at ProtoBuf.Reflect.FieldPrototype.verifyValue (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:3417:43)
    at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2443:59)
    at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2434:38)
    at Message (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2363:34)
    at serialize (/Users/stephen/dev/play/gissue-1205/node_modules/grpc/src/node/src/common.js:87:23)

@pcostell any thoughts on what might be the trouble here? Thanks!

[pcostell]

My guess is you hit a point where the keys are deferred:
https://github.com/googleapis/googleapis/blob/master/google/datastore/v1beta3/datastore.proto#L96

However, I don't know why it would fail in this way.

On Tue, Aug 16, 2016 at 11:52 AM Stephen Sawchuk notifications@github.com
wrote:

Steps to reproduce

'use strict'
var gcloud = require('gcloud')
var datastore = gcloud.datastore()
var keys = []
// var num = 300 // worksvar num = 350 // failswhile (num--) {
keys.push(datastore.key(['Kind', num + 1]))
}
datastore.get(keys, console.log)

prints an error:

/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2440
throw Error(this+"#"+keyOrObj+" is not a field: undefined");
^

Error: .google.datastore.v1beta3.Key#id is not a field: undefined
at Error (native)
at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2440:35)
at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2434:38)
at Message (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2363:34)
at ProtoBuf.Reflect.ElementPrototype.verifyValue (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:1877:28)
at ProtoBuf.Reflect.FieldPrototype.verifyValue (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:3417:43)
at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2443:59)
at MessagePrototype.set (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2434:38)
at Message (/Users/stephen/dev/play/gissue-1205/node_modules/protobufjs/dist/ProtoBuf.js:2363:34)
at serialize (/Users/stephen/dev/play/gissue-1205/node_modules/grpc/src/node/src/common.js:87:23)

@pcostell https://github.com/pcostell any thoughts on what might be the
trouble here? Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1497, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABpeM14_edWHgd4XN7Aj-d_wLqT2rvg3ks5qggbigaJpZM4Jlu2i
.

Patrick Costello | Cloud Datastore | Software Engineer |
pcostello@google.com

[stephenplusplus]

Thanks for the lead! PR sent with a fix: #1498