Skip to content

Don't require an options object for Service instantiations #2562

@stephenplusplus

Description

@stephenplusplus

With ADC auth, it's possible users don't need to provide any options object to a Service instantiation. That currently causes this line to throw:

https://github.com/GoogleCloudPlatform/google-cloud-node/blob/c98acd27ad8718a2c78bffa9b0f253cc334334b9/packages/common/src/service.js#L50

We should default options to an empty object.

Metadata

Metadata

Labels

coretype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions