PubSub's ConnectionPool doesn't replace the {{projectId}} placeholder

[jviide]

Environment details

• OS: MacOS 10.12.6
• Node.js version: 8.4.0
• npm version: 5.3.0
• google-cloud-node version: 0.14.0

Steps to reproduce

Running the following example code:

const pubsub = require("@google-cloud/pubsub")();

pubsub
  .createTopic("test-topic")
  .then(
    ([topic]) => topic,
    err => {
      if (err.code === 6) {
        return pubsub.topic("test-topic");
      }
      throw err;
    }
  )
  .then(topic => {
    return topic.createSubscription("test-subscription");
  })
  .then(([sub]) => {
    sub.on("message", () => {});
    sub.on("error", err => {
      throw err;
    });
  });

crashes with the error message:

Error: Requested project not found or user does not have access to it (project={{projectId}}). Make sure to specify the unique project identifier and not the Google Cloud Console display name.
    at ClientDuplexStream.<anonymous> (./node_modules/@google-cloud/pubsub/src/connection-pool.js:223:21)
    at emitOne (events.js:115:13)
    at ClientDuplexStream.emit (events.js:210:7)
    at ClientDuplexStream._emitStatusIfDone (./node_modules/grpc/src/node/src/client.js:260:10)
    at ClientDuplexStream._receiveStatus (./node_modules/grpc/src/node/src/client.js:233:8)
    at ./node_modules/grpc/src/node/src/client.js:757:12

The ConnectionPool#createConnection implementation might play a part in this. The connection.write call on lines 232-235 uses a subscription name where the {{projectId}} placeholder has not been replaced with the actual project id.

[mscottx88]

@stephenplusplus

Is this issue resolved? I am still seeing this error on version 0.14.0.

I can confirm that in debug mode, when getting to the Subscription constructor, pubsub.projectId still says {{projectId}}. Manually replacing it with the correct value at run time works and messages are received.

When will this be resolved?

Also, if you specify the projectId on the Pubsub function call, it also works, but that kind of takes a step back in functionality as compared to the Default Credentials approach and key file approach, which has the projectId already embedded in it.