-
Notifications
You must be signed in to change notification settings - Fork 639
Closed
Labels
api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.
Milestone
Description
Related: #621
Should we privatize transaction#begin and transaction#commit, removing them from the public docs and their usage in other Transaction examples?
A user goes through their Dataset instance to get a Transaction:
dataset.runInTransaction(transaction, done) {});This calls transaction.begin immediately, and the done function returned to their callback is actually transaction.commit.
Having these methods appear in the docs is probably quite confusing, as the user shouldn't need (or be able to) begin a transaction that already began, or commit the transaction before calling done (commit) again.
Metadata
Metadata
Assignees
Labels
api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.