Skip to content

search: use native querystring module for returnFields API request #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
callmehiphop merged 1 commit into from
Dec 9, 2015
Merged

search: use native querystring module for returnFields API request #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/search/index-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,8 @@ Index.prototype.search = function(query, callback) {

this.request({
uri: '/search',
qs: query
qs: query,
useQuerystring: true // See #986.
}, function(err, resp) {
if (err) {
callback(err, null, null, resp);
Expand Down
17 changes: 14 additions & 3 deletions system-test/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,13 @@ describe('Search', function() {

before(function(done) {
var questions = document.addField('question');
var answers = document.addField('answer');

questions.addTextValue('Where did Ryan go?');
questions.addTextValue('Where did Silvano go?');

answers.addTextValue('Where DIDN\'T they go?');

This comment was marked as spam.

Sign in to view


document.create(done);
});

Expand All @@ -231,10 +234,18 @@ describe('Search', function() {
});

it('should search document', function(done) {
index.search(query, function(err, results) {
var fields = ['question', 'answer'];

index.search({
query: query,
returnFields: fields,
}, function(err, results) {
assert.ifError(err);
assert.equal(results.length, 1);
assert.equal(results[0].id, DOCUMENT_NAME);
assert.strictEqual(results.length, 1);

var document = results[0];
assert.strictEqual(document.id, DOCUMENT_NAME);
assert.strictEqual(Object.keys(document.fields).length, fields.length);
done();
});
});
Expand Down
9 changes: 9 additions & 0 deletions test/search/index-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,15 @@ describe('Index', function() {
index.search(query, assert.ifError);
});

it('should use default querystring module', function(done) {
index.request = function(reqOpts) {
assert.strictEqual(reqOpts.useQuerystring, true);
done();
};

index.search('', assert.ifError);
});

it('should execute callback with error & API response', function(done) {
var apiResponse = { a: 'b', c: 'd' };
var error = new Error('Error.');
Expand Down