Skip to content

Fixed: prediction/model#query does not work with Regression models #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
savethefails wants to merge 3 commits into from
Closed

Fixed: prediction/model#query does not work with Regression models #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
729c8c5
Changed test "query success should return the outputValue as the winn…
savethefails Mar 13, 2016
34f6b12
Removed 'scores' from returned results of prediction/model#query when…
savethefails Mar 13, 2016
7920dc7
Added name to authors/contributors as per [contributing guidelines](h…
savethefails Mar 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@

Google Inc.
Anand Suresh
Brett Bergmann
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# Keep the list alphabetically sorted.

Burcu Dogan <jbd@google.com>
Brett Bergmann <me@brettbergmann.com>
Johan Euphrosine <proppy@google.com>
Marco Ziccardi <marco.ziccard@gmail.com>
Patrick Costello <pcostell@google.com>
Expand Down
5 changes: 4 additions & 1 deletion lib/prediction/model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,10 @@ Model.prototype.query = function(input, callback) {

var results = {
winner: resp.outputLabel || resp.outputValue,
scores: resp.outputMulti
};

if (resp.outputMulti){
results.scores = resp.outputMulti
.sort(function(a, b) {
return a.score < b.score ? 1 : a.score > b.score ? -1 : 0;
})
Expand Down
1 change: 1 addition & 0 deletions test/prediction/model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ describe('Index', function() {
});

delete apiResponseWithValue.outputLabel;
delete apiResponseWithValue.outputMulti;

model.request = function(reqOpts, callback) {
callback(null, apiResponseWithValue);
Expand Down