Skip to content

treat partial errors as callback(err)ors #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 12 commits into from
Nov 7, 2016
Merged

treat partial errors as callback(err)ors #1760

callmehiphop merged 12 commits into from
Nov 7, 2016

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Oct 31, 2016 •
edited
Loading

Fixes #1644

To Dos

@stephenplusplus stephenplusplus added api: bigquery Issues related to the BigQuery API. don't merge api: bigtable Issues related to the Bigtable API. api: vision Issues related to the Cloud Vision API. labels Oct 31, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2016
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Nov 1, 2016

@callmehiphop PTAL

callmehiphop
callmehiphop reviewed Nov 1, 2016
View reviewed changes
packages/vision/src/index.js Outdated
.map(decorateAnnotations)
.filter(function(annotation) {
// Remove annotations that had errors.
return annotation;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop
callmehiphop reviewed Nov 1, 2016
View reviewed changes
packages/bigquery/src/table.js Outdated
* // recommendations on handling errors.
* // An API error or partial failure occurred.
*
* if (err.name === 'PartialFailureError') {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus mentioned this pull request Nov 2, 2016
Merged
@stephenplusplus stephenplusplus added status: blocked Resolving the issue is dependent on other work. and removed don't merge labels Nov 2, 2016
@stephenplusplus stephenplusplus force-pushed the spp--1644 branch 3 times, most recently from dc9c83b to 368cde6 Compare November 4, 2016 19:16
@stephenplusplus stephenplusplus mentioned this pull request Nov 4, 2016
Merged
@stephenplusplus stephenplusplus removed the status: blocked Resolving the issue is dependent on other work. label Nov 7, 2016
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Nov 7, 2016

Ready for a final sign off, @callmehiphop!

callmehiphop
callmehiphop reviewed Nov 7, 2016
View reviewed changes
packages/bigquery/src/table.js Outdated
* //-
* // Handling the response.
* //-
* function insertHandler(err, insertErrors, apiResponse) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/bigquery/src/table.js Outdated
* // recommendations on handling errors.
* // An API error or partial failure occurred.
*
* if (err.name === 'PartialFailureError') {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/bigquery/src/table.js Outdated
*
* // err.errors (object[]):
* // err.errors[].row (original row object passed to `insert`)
* // err.errors[].errors[].reason

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/bigquery/src/table.js Outdated
* // err.errors[].errors[].reason
* // err.errors[].errors[].message
*
* // See https://developers.google.com/bigquery/troubleshooting-errors for

This comment was marked as spam.

Sign in to view

packages/bigquery/system-test/bigquery.js Outdated
it('should return partial errors', function(done) {
var data = {
name: 'dave',
breed: 'british shorthair',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/bigtable/src/table.js
* //-
* var callback = function(err, mutationErrors) {
* var callback = function(err) {
* if (err) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/vision/src/index.js Outdated
* if (detections.faces.errors.length > 0) {
* // Errors occurred while trying to use this image for a face annotation.
* if (err && err.name === 'PartialFailureError') {
* err.errors = [

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus mentioned this pull request Nov 7, 2016
Closed
@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Nov 7, 2016

PTAL!

callmehiphop
callmehiphop reviewed Nov 7, 2016
View reviewed changes
packages/bigquery/system-test/bigquery.js
it('should return partial errors', function(done) {
var data = {
name: 'dave',
breed: 'british husky',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@callmehiphop callmehiphop merged commit b6270e5 into googleapis:master Nov 7, 2016
@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@stephenplusplus @callmehiphop
treat partial errors as callback(err)ors (#1760)
1e48eb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@callmehiphop callmehiphop callmehiphop left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. api: bigtable Issues related to the Bigtable API. api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenplusplus @callmehiphop @googlebot