common: Added silent log level and option to specify custom log levels #1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
Can you add a test to confirm a user's levels are honored? |
Contributor
Author
|
@stephenplusplus Yep, see 80b4f3b |
Contributor
|
Great, thanks! |
Contributor
Author
|
@stephenplusplus Could you publish this under npm? Thanks! |
Contributor
|
Sure thing! Just published |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'silent'is now the minimum log level. This allows one to not get any log output (since logging at'silent'level is inherently discouraged by the level name), and aligns with thelogLevelconfiguration option in the diagnostics agents.Also, the
loggerconstructor accepts an alternative list of levels other thanlogger.LEVELS.