error-reporting: Remove Credential Validation Checks#2246
Merged
DominicKramer merged 1 commit intogoogleapis:masterfrom Apr 21, 2017
Merged
Conversation
googlebot
added
the
cla: yes
DominicKramer
changed the title
error-reporting Only Supports Authentication Using a Service Account Key
|
Changes Unknown when pulling 344d973 on DominicKramer:bug/2245-local-reporting-fails into ** on GoogleCloudPlatform:master**. |
Instead, the `@google-cloud/common` module will handle credential verification. Without this fix, the `error-reporting` library's checks for valid credentials were incorrect and would think that communication with the API would fail even though that was not the case. As a result, the library would not attempt to communicate with the API even though the communication would succeed. With this change, the error reporting library will always communicate with the API and will leave it to the `@google-cloud/common` module to handle issues with invalid credentials. Fixes googleapis#2245 - `error-reporting` Only Supports Authentication Using a Service Account Key.
DominicKramer
force-pushed
the
bug/2245-local-reporting-fails
branch
from
344d973 to
4b714bc
Compare
DominicKramer
changed the title
error-reporting Only Supports Authentication Using a Service Account Key
DominicKramer
changed the title
DominicKramer
changed the title
ofrobots
changed the title
|
Changes Unknown when pulling 4b714bc on DominicKramer:bug/2245-local-reporting-fails into ** on GoogleCloudPlatform:master**. |
ofrobots
approved these changes
Apr 21, 2017
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
LGTM. Please follow-on with a smarter warning that is based on the ability to create an auth client.
Contributor
|
For now, let's prefer @stephenplusplus land things. |
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
Instead, the `@google-cloud/common` module will handle credential verification. Without this fix, the `error-reporting` library's checks for valid credentials were incorrect and would think that communication with the API would fail even though that was not the case. As a result, the library would not attempt to communicate with the API even though the communication would succeed. With this change, the error reporting library will always communicate with the API and will leave it to the `@google-cloud/common` module to handle issues with invalid credentials. Fixes #2245
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
Instead, the `@google-cloud/common` module will handle credential verification. Without this fix, the `error-reporting` library's checks for valid credentials were incorrect and would think that communication with the API would fail even though that was not the case. As a result, the library would not attempt to communicate with the API even though the communication would succeed. With this change, the error reporting library will always communicate with the API and will leave it to the `@google-cloud/common` module to handle issues with invalid credentials. Fixes #2245
4 tasks
GautamSharda
pushed a commit
that referenced
this pull request
Feb 5, 2026
Instead, the `@google-cloud/common` module will handle credential verification. Without this fix, the `error-reporting` library's checks for valid credentials were incorrect and would think that communication with the API would fail even though that was not the case. As a result, the library would not attempt to communicate with the API even though the communication would succeed. With this change, the error reporting library will always communicate with the API and will leave it to the `@google-cloud/common` module to handle issues with invalid credentials. Fixes #2245
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2245 -
error-reportingOnly Supports AuthenticationUsing a Service Account Key.